Skip to content

feat: replace legacy branch categories with product_name by conversion - #1336

Open
bshek-xitaso wants to merge 2 commits into
csaf-rs:mainfrom
bshek-xitaso:feat/1046-replace-legacy-branch-category
Open

bshek-xitaso wants to merge 2 commits into
csaf-rs:mainfrom
bshek-xitaso:feat/1046-replace-legacy-branch-category

Conversation

@bshek-xitaso

Copy link
Copy Markdown
Contributor

This PR resolves #1046.

@bshek-xitaso
bshek-xitaso marked this pull request as ready for review October 21, 2026 15:31
@bshek-xitaso
bshek-xitaso requested a review from a team as a code owner October 21, 2026 15:31

@Gronner Gronner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall functionality is good and this could be merged this way. The helper function should return something to indicate success or that errors where present.

Comment thread csaf-rs/src/converter/helpers.rs Resolved
Comment thread csaf-rs/src/converter/helpers.rs Resolved
@bshek-xitaso
bshek-xitaso marked this pull request as draft October 22, 2026 04:56
@bshek-xitaso
bshek-xitaso force-pushed the feat/1046-replace-legacy-branch-category branch from 9a452d4 to 2ada8a1 Compare October 30, 2026 13:52
@bshek-xitaso
bshek-xitaso force-pushed the feat/1046-replace-legacy-branch-category branch from be745e3 to be613a0 Compare November 10, 2026 16:56
@bshek-xitaso
bshek-xitaso marked this pull request as ready for review November 10, 2026 17:05

@Gronner Gronner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

converter: branch change from legacy

4 participants